fix(semantic): improve HTML semantics across templates#1721
Open
miaulalala wants to merge 1 commit intomasterfrom
Open
fix(semantic): improve HTML semantics across templates#1721miaulalala wants to merge 1 commit intomasterfrom
miaulalala wants to merge 1 commit intomasterfrom
Conversation
- Replace navbar-default class on <footer> with site-footer
- Extract filter form out of <ul class="nav-tabs"> into its own sibling element
- Convert .app-meta <div> to <aside aria-label="App information"> on detail page
- Merge duplicate {% if request.user.is_authenticated %} blocks in nav.html
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
Signed-off-by: Anna Larch <anna@nextcloud.com>
edward-ly
requested changes
Mar 22, 2026
Collaborator
edward-ly
left a comment
edward-ly
left a comment
There was a problem hiding this comment.
Everything looks good apart from one breaking change: while it might make sense to add more visual separation the sort and filter options, there seems to be an issue with the flex layout for the sorting options on smaller screens.
Here's what the options row look like on the master branch.
And here's what the PR changes look like on the same screen. The rating sort is not accessible anymore, in this case.
Make sure the options row remain responsive to the screen width (preferably by restoring the wrapping behavior, but if you have a better solution, I'm all ears).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<footer>with site-footer<ul class="nav-tabs">into its own sibling element<div>to<aside aria-label="App information">on detail page{% if request.user.is_authenticated %}blocks in nav.html